Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Replaced newsletter with Google Groups #1017

Merged
merged 9 commits into from
Jan 24, 2024

Conversation

goodalse2019
Copy link
Collaborator

@goodalse2019 goodalse2019 commented Jan 23, 2024

[DOC]

Closes #1011.

Changes proposed in this pull request:

  • Updated all mentions of tinyletter newsletter with google groups link

Changed newsletter from TinyLetter to new google groups link.
Changed newsletter link from TinyLetter to Google Groups
Changed the content from tinyletter to google groups
updated newsletter link to google groups
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.44%. Comparing base (f2a8325) to head (c8f0d44).
Report is 58 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1017   +/-   ##
=======================================
  Coverage   89.44%   89.44%           
=======================================
  Files          26       26           
  Lines        3420     3420           
  Branches      624      624           
=======================================
  Hits         3059     3059           
  Misses        210      210           
  Partials      151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @goodalse2019!

I think we may want to be consistent with capitalization of "Google Groups" throughout our docs. I have added the suggestions inline so it's easier for you to add them.

README.md Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
goodalse2019 and others added 2 commits January 23, 2024 13:41
Co-authored-by: Eneko Uruñuela <e.urunuela@icloud.com>
Co-authored-by: Eneko Uruñuela <e.urunuela@icloud.com>
@goodalse2019
Copy link
Collaborator Author

Oh yes, agree! Updated - thanks!

@goodalse2019
Copy link
Collaborator Author

I am not sure why the ci/circleci checks are failing - they were not when I first submitted the PR. Is that an error on my end? Can it still be merged regardless? It continually is the "five-echo", "four-echo", "reclassify", and the "three-echo". I can close PR and reopen if that would help. Thanks!

@eurunuela
Copy link
Collaborator

eurunuela commented Jan 24, 2024

It looks like the tests were cancelled, maybe with your new commits? In any case, they did pass for your last commit.

Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@handwerkerd handwerkerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@handwerkerd handwerkerd merged commit eeda53c into ME-ICA:main Jan 24, 2024
16 checks passed
@handwerkerd
Copy link
Member

@all-contributors please add @goodalse2019 for doc, ideas, question

Copy link
Contributor

@handwerkerd

I've put up a pull request to add @goodalse2019! 🎉

@handwerkerd
Copy link
Member

I just ported our TinyLetter mailing list members to the new google group.
The way the group is currently set up, very few people will be allowed to post. I've made the following people managers so that they will be able to add/remove people and post: @eurunuela @goodalse2019 @n-reddy @tsalo @dowdlelt If you do or do not want this awesome power, please let me know.

As the list is currently set up, you can only post to the group from the web interface. I did this to make it impossible for any of us to accidentally reply to a message and send the reply to the entire group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TinyLetter shutting down
3 participants