-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Replaced newsletter with Google Groups #1017
Conversation
Changed newsletter from TinyLetter to new google groups link.
Changed newsletter link from TinyLetter to Google Groups
Changed the content from tinyletter to google groups
updated newsletter link to google groups
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1017 +/- ##
=======================================
Coverage 89.44% 89.44%
=======================================
Files 26 26
Lines 3420 3420
Branches 624 624
=======================================
Hits 3059 3059
Misses 210 210
Partials 151 151 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @goodalse2019!
I think we may want to be consistent with capitalization of "Google Groups" throughout our docs. I have added the suggestions inline so it's easier for you to add them.
Co-authored-by: Eneko Uruñuela <e.urunuela@icloud.com>
Co-authored-by: Eneko Uruñuela <e.urunuela@icloud.com>
Oh yes, agree! Updated - thanks! |
I am not sure why the ci/circleci checks are failing - they were not when I first submitted the PR. Is that an error on my end? Can it still be merged regardless? It continually is the "five-echo", "four-echo", "reclassify", and the "three-echo". I can close PR and reopen if that would help. Thanks! |
It looks like the tests were cancelled, maybe with your new commits? In any case, they did pass for your last commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@all-contributors please add @goodalse2019 for doc, ideas, question |
I've put up a pull request to add @goodalse2019! 🎉 |
I just ported our TinyLetter mailing list members to the new google group. As the list is currently set up, you can only post to the group from the web interface. I did this to make it impossible for any of us to accidentally reply to a message and send the reply to the entire group. |
Closes #1011.
Changes proposed in this pull request: